[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y2Uz4Sea8xekgpyR@lunn.ch>
Date: Fri, 4 Nov 2022 16:46:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Yang Li <yang.lee@...ux.alibaba.com>
Cc: richardcochran@...il.com, bagasdotme@...il.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next v3] net: ethernet: Simplify bool conversion
On Fri, Nov 04, 2022 at 02:37:31PM +0800, Yang Li wrote:
> The result of 'scaled_ppm < 0' is Boolean, and the question mark
> expression is redundant, remove it to clear the below warning:
>
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>
> change in v3:
> --According to Richard's suggestion, to preserve reverse Christmas tree order.
Don't send a new version of a patch for at least 24 hours.
https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
People need time to review your patch and suggest how to make it
better.
Andrew
Powered by blists - more mailing lists