[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2U2+ePwRieYkNjv@sirena.org.uk>
Date: Fri, 4 Nov 2022 15:59:53 +0000
From: Mark Brown <broonie@...nel.org>
To: Maxime Ripard <maxime@...no.tech>
Cc: Stephen Boyd <sboyd@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Chen-Yu Tsai <wens@...e.org>, Daniel Vetter <daniel@...ll.ch>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Thierry Reding <thierry.reding@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Shawn Guo <shawnguo@...nel.org>,
Fabio Estevam <festevam@...il.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Michael Turquette <mturquette@...libre.com>,
Dinh Nguyen <dinguyen@...nel.org>,
Paul Cercueil <paul@...pouillou.net>,
Chunyan Zhang <zhang.lyra@...il.com>,
Manivannan Sadhasivam <mani@...nel.org>,
Andreas Färber <afaerber@...e.de>,
Jonathan Hunter <jonathanh@...dia.com>,
Abel Vesa <abelvesa@...nel.org>,
Charles Keepax <ckeepax@...nsource.cirrus.com>,
Alessandro Zummo <a.zummo@...ertech.it>,
Peter De Schrijver <pdeschrijver@...dia.com>,
Orson Zhai <orsonzhai@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Prashant Gaikwad <pgaikwad@...dia.com>,
Liam Girdwood <lgirdwood@...il.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Samuel Holland <samuel@...lland.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Vinod Koul <vkoul@...nel.org>,
NXP Linux Team <linux-imx@....com>,
Sekhar Nori <nsekhar@...com>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Takashi Iwai <tiwai@...e.com>,
David Airlie <airlied@...il.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
David Lechner <david@...hnology.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Max Filippov <jcmvbkbc@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
linux-stm32@...md-mailman.stormreply.com,
alsa-devel@...a-project.org, linux-mediatek@...ts.infradead.org,
linux-phy@...ts.infradead.org, linux-mips@...r.kernel.org,
linux-renesas-soc@...r.kernel.org,
linux-actions@...ts.infradead.org, linux-clk@...r.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
patches@...nsource.cirrus.com, linux-tegra@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook
On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote:
> Just filling determine_rate if it's missing with
> __clk_mux_determine_rate will possibly pick different parents, and I'm
> fairly certain that this have never been tested on most platforms, and
> will be completely broken. And I don't really want to play a game of
> whack-a-mole adding that flag everywhere it turns out it's broken.
Well, hopefully everyone for whom it's an issue currently will be
objecting to this version of the change anyway so we'll either know
where to set the flag or we'll get the whack-a-mole with the series
being merged?
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists