linux-kernel - Aw: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-889b4468-8a50-4eae-80a1-6bd9ffbeaaf2-1667577856206@3c-app-gmx-bs24>
Date:   Fri, 4 Nov 2022 17:04:16 +0100
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Frank Wunderlich <linux@...web.de>,
        linux-mediatek@...ts.infradead.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Aw: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings
 for MT7986 SoC

Hi

> Gesendet: Dienstag, 25. Oktober 2022 um 20:35 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>
> Betreff: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC
>
> On 25/10/2022 03:02, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> >
> > Add new splitted uart pins and emmc_51
> >
> > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

after talking with MTK for the emmc pinctrl settings (custom pull-up) they suggested me to change
binding to fix other emmc-values and allow multiple (2) uart-items

so on top of this patch

             then:
               properties:
                 groups:
-                  enum: [emmc, emmc_rst, emmc_51]
+                  enum: [emmc_45, emmc_51]
           - if:
               properties:
                 function:
@@ -231,10 +231,12 @@ patternProperties:
             then:
               properties:
                 groups:
-                  enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1,
-                         uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx,
-                         uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts,
-                         uart2_1, uart0, uart1, uart2]
+                  items:
+                    enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1,
+                           uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx,
+                           uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts,
+                           uart2_1, uart0, uart1, uart2]
+                  maxItems: 2

i would squash these changes and send as v3 or should i send an extra-patch?

regards Frank