linux-kernel - Re: Linux 4.14.297

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2YzeruPdM2y327C@kroah.com>
Date:   Sat, 5 Nov 2022 10:57:14 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        torvalds@...ux-foundation.org, stable@...r.kernel.org, lwn@....net,
        jslaby@...e.cz
Subject: Re: Linux 4.14.297

On Fri, Nov 04, 2022 at 11:17:45AM -0700, Nick Desaulniers wrote:
> On Tue, Nov 01, 2022 at 07:24:13PM +0100, Greg Kroah-Hartman wrote:
> > I'm announcing the release of the 4.14.297 kernel.
> > 
> > All users of the 4.14 kernel series must upgrade.
> > 
> > The updated 4.14.y git tree can be found at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y
> > and can be browsed at the normal kernel.org git web browser:
> > 	https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
> 
> Hi Greg and stable tree maintainers,
> Please consider cherry-picking
> commit 95b980d62d52 ("linux/bits.h: make BIT(), GENMASK(), and friends available in assembly")
> back to 4.19.y and 4.14.y. It first landed in v5.3-rc1 and applies
> cleanly to both branches. I did not find any fixups to 95b980d62d52,
> FWIW.
> 
> Otherwise users upgrading to this point release of linux-4.14.y still on
> versions of the GNU assembler older than v1.28 will observe assembler
> errors when building this series. See the link below for the error
> messages.
> 
> Please see
> https://lore.kernel.org/llvm/20221103210748.1343090-1-ndesaulniers@google.com/
> for more info.

Did you try building with that commit applied?  I get the following
build error when running it through the Android build system:

In file included from /buildbot/src/android/q-common-android-4.14/common/arch/arm64/include/asm/bitops.h:49:
/buildbot/src/android/q-common-android-4.14/common/include/asm-generic/bitops/non-atomic.h:60:23: error: implicit declaration of function 'UL' [-Werror,-Wimplicit-function-declaration]
        unsigned long mask = BIT_MASK(nr);
                             ^
/buildbot/src/android/q-common-android-4.14/common/include/linux/bits.h:10:24: note: expanded from macro 'BIT_MASK'
#define BIT_MASK(nr)            (UL(1) << ((nr) % BITS_PER_LONG))

So are you sure this is the correct fix?

thanks,

greg k-h