linux-kernel - Re: [PATCH] selftests/bpf: Fix unsigned expression compared with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+uqrQA7phtFFs-=eYroademz2F-5+1yCPMZVcErxnpKxEfi_g@mail.gmail.com>
Date:   Sat, 5 Nov 2022 19:21:55 +0900
From:   Kang Minchul <tegongkang@...il.com>
To:     Björn Töpel <bjorn@...nel.org>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix unsigned expression compared with zero

2022년 11월 5일 (토) 오후 7:18, Kang Minchul <tegongkang@...il.com>님이 작성:
>
> Variable ret is compared with zero even though it have set as u32.
> So u32 to int conversion is needed.
>
> Signed-off-by: Kang Minchul <tegongkang@...il.com>
> ---
>  tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
> index 681a5db80dae..162d3a516f2c 100644
> --- a/tools/testing/selftests/bpf/xskxceiver.c
> +++ b/tools/testing/selftests/bpf/xskxceiver.c
> @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
>  {
>         struct xsk_socket_info *xsk = ifobject->xsk;
>         bool use_poll = ifobject->use_poll;
> -       u32 i, idx = 0, ret, valid_pkts = 0;
> +       u32 i, idx = 0, valid_pkts = 0;
> +       int ret;
>
>         while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
>                 if (use_poll) {
> --
> 2.34.1
>

I just found a grammatical error in the commit message.
I'll resend this with the correct message.
Sorry for the inconvenience.

Regards,

Kang Minchul