lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABb+yY1moe2DmU9xJ0xR=U12ECmeHjN-cxfDYiw9ZBpcxRFp-g@mail.gmail.com>
Date:   Sat, 5 Nov 2022 10:24:01 -0500
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     jqlhn <jqlhn@....com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:mailbox Using kfifo to store buffered message data

On Fri, Nov 4, 2022 at 10:36 PM jqlhn <jqlhn@....com> wrote:
>
> In current mailbox, a self implemented message array to be used
> as message fifo, I am replacing it with kernel kfifo,
> in order to make code cleaner.
>
> Signed-off-by: jqlhn <jqlhn@....com>
> ---
>  drivers/mailbox/mailbox.c          | 33 ++++++++----------------------
>  drivers/mailbox/omap-mailbox.c     |  3 +--
>  drivers/mailbox/pcc.c              |  3 +--
>  include/linux/mailbox_controller.h | 10 ++++-----
>  4 files changed, 14 insertions(+), 35 deletions(-)
>
The circular buffer was implemented using an array because it is
simple enough and we wanted to keep tight control over the efficiency.
While you do manage to reduce 21 lines from 4 files, I am not sure
that is a reasonable tradeoff between readability and history plus
actual overhead of execution.

thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ