lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 6 Nov 2022 05:45:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-spi@...r.kernel.org, openbmc@...ts.ozlabs.org
Cc:     oe-kbuild-all@...ts.linux.dev, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH 7/8] spi: wpcm-fiu: Add driver for Nuvoton WPCM450 Flash
 Interface Unit (FIU)

Hi Jonathan,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20221104]
[cannot apply to broonie-spi/for-next linusw-pinctrl/devel robh/for-next v6.1-rc3 v6.1-rc2 v6.1-rc1 linus/master v6.1-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jonathan-Neusch-fer/Nuvoton-WPCM450-FIU-SPI-flash-controller/20221106-030021
patch link:    https://lore.kernel.org/r/20221105185911.1547847-8-j.neuschaefer%40gmx.net
patch subject: [PATCH 7/8] spi: wpcm-fiu: Add driver for Nuvoton WPCM450 Flash Interface Unit (FIU)
config: powerpc-allmodconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3d22f2e9e9e1e5bccc9665a9c6d4c32e3ccddfa8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jonathan-Neusch-fer/Nuvoton-WPCM450-FIU-SPI-flash-controller/20221106-030021
        git checkout 3d22f2e9e9e1e5bccc9665a9c6d4c32e3ccddfa8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/spi/spi-wpcm-fiu.c:296:11: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     296 |         { wpcm_fiu_normal_match, wpcm_fiu_normal_exec },
         |           ^~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:296:11: note: (near initialization for 'wpcm_fiu_op_shapes[0]')
   drivers/spi/spi-wpcm-fiu.c:296:11: error: invalid initializer
   drivers/spi/spi-wpcm-fiu.c:296:11: note: (near initialization for 'wpcm_fiu_op_shapes[0].<anonymous>')
   drivers/spi/spi-wpcm-fiu.c:296:34: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     296 |         { wpcm_fiu_normal_match, wpcm_fiu_normal_exec },
         |                                  ^~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:296:34: note: (near initialization for 'wpcm_fiu_op_shapes[0]')
>> drivers/spi/spi-wpcm-fiu.c:296:34: error: initialization of 'bool (*)(const struct spi_mem_op *)' {aka '_Bool (*)(const struct spi_mem_op *)'} from incompatible pointer type 'int (*)(struct spi_mem *, const struct spi_mem_op *)' [-Werror=incompatible-pointer-types]
   drivers/spi/spi-wpcm-fiu.c:296:34: note: (near initialization for 'wpcm_fiu_op_shapes[0].match')
   drivers/spi/spi-wpcm-fiu.c:297:11: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     297 |         { wpcm_fiu_fast_read_match, wpcm_fiu_fast_read_exec },
         |           ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:297:11: note: (near initialization for 'wpcm_fiu_op_shapes[1]')
   drivers/spi/spi-wpcm-fiu.c:297:11: error: invalid initializer
   drivers/spi/spi-wpcm-fiu.c:297:11: note: (near initialization for 'wpcm_fiu_op_shapes[1].<anonymous>')
   drivers/spi/spi-wpcm-fiu.c:297:37: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     297 |         { wpcm_fiu_fast_read_match, wpcm_fiu_fast_read_exec },
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:297:37: note: (near initialization for 'wpcm_fiu_op_shapes[1]')
   drivers/spi/spi-wpcm-fiu.c:297:37: error: initialization of 'bool (*)(const struct spi_mem_op *)' {aka '_Bool (*)(const struct spi_mem_op *)'} from incompatible pointer type 'int (*)(struct spi_mem *, const struct spi_mem_op *)' [-Werror=incompatible-pointer-types]
   drivers/spi/spi-wpcm-fiu.c:297:37: note: (near initialization for 'wpcm_fiu_op_shapes[1].match')
   drivers/spi/spi-wpcm-fiu.c:298:11: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     298 |         { wpcm_fiu_4ba_match, wpcm_fiu_4ba_exec },
         |           ^~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:298:11: note: (near initialization for 'wpcm_fiu_op_shapes[2]')
   drivers/spi/spi-wpcm-fiu.c:298:11: error: invalid initializer
   drivers/spi/spi-wpcm-fiu.c:298:11: note: (near initialization for 'wpcm_fiu_op_shapes[2].<anonymous>')
   drivers/spi/spi-wpcm-fiu.c:298:31: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     298 |         { wpcm_fiu_4ba_match, wpcm_fiu_4ba_exec },
         |                               ^~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:298:31: note: (near initialization for 'wpcm_fiu_op_shapes[2]')
   drivers/spi/spi-wpcm-fiu.c:298:31: error: initialization of 'bool (*)(const struct spi_mem_op *)' {aka '_Bool (*)(const struct spi_mem_op *)'} from incompatible pointer type 'int (*)(struct spi_mem *, const struct spi_mem_op *)' [-Werror=incompatible-pointer-types]
   drivers/spi/spi-wpcm-fiu.c:298:31: note: (near initialization for 'wpcm_fiu_op_shapes[2].match')
   drivers/spi/spi-wpcm-fiu.c:299:11: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     299 |         { wpcm_fiu_rdid_match, wpcm_fiu_rdid_exec },
         |           ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:299:11: note: (near initialization for 'wpcm_fiu_op_shapes[3]')
   drivers/spi/spi-wpcm-fiu.c:299:11: error: invalid initializer
   drivers/spi/spi-wpcm-fiu.c:299:11: note: (near initialization for 'wpcm_fiu_op_shapes[3].<anonymous>')
   drivers/spi/spi-wpcm-fiu.c:299:32: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     299 |         { wpcm_fiu_rdid_match, wpcm_fiu_rdid_exec },
         |                                ^~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:299:32: note: (near initialization for 'wpcm_fiu_op_shapes[3]')
   drivers/spi/spi-wpcm-fiu.c:299:32: error: initialization of 'bool (*)(const struct spi_mem_op *)' {aka '_Bool (*)(const struct spi_mem_op *)'} from incompatible pointer type 'int (*)(struct spi_mem *, const struct spi_mem_op *)' [-Werror=incompatible-pointer-types]
   drivers/spi/spi-wpcm-fiu.c:299:32: note: (near initialization for 'wpcm_fiu_op_shapes[3].match')
   drivers/spi/spi-wpcm-fiu.c:300:11: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     300 |         { wpcm_fiu_dummy_match, wpcm_fiu_dummy_exec },
         |           ^~~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:300:11: note: (near initialization for 'wpcm_fiu_op_shapes[4]')
   drivers/spi/spi-wpcm-fiu.c:300:11: error: invalid initializer
   drivers/spi/spi-wpcm-fiu.c:300:11: note: (near initialization for 'wpcm_fiu_op_shapes[4].<anonymous>')
   drivers/spi/spi-wpcm-fiu.c:300:33: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     300 |         { wpcm_fiu_dummy_match, wpcm_fiu_dummy_exec },
         |                                 ^~~~~~~~~~~~~~~~~~~
   drivers/spi/spi-wpcm-fiu.c:300:33: note: (near initialization for 'wpcm_fiu_op_shapes[4]')
   drivers/spi/spi-wpcm-fiu.c:300:33: error: initialization of 'bool (*)(const struct spi_mem_op *)' {aka '_Bool (*)(const struct spi_mem_op *)'} from incompatible pointer type 'int (*)(struct spi_mem *, const struct spi_mem_op *)' [-Werror=incompatible-pointer-types]
   drivers/spi/spi-wpcm-fiu.c:300:33: note: (near initialization for 'wpcm_fiu_op_shapes[4].match')
   cc1: some warnings being treated as errors


vim +296 drivers/spi/spi-wpcm-fiu.c

   294	
   295	static const struct wpcm_fiu_op_shape wpcm_fiu_op_shapes[] = {
 > 296		{ wpcm_fiu_normal_match, wpcm_fiu_normal_exec },
   297		{ wpcm_fiu_fast_read_match, wpcm_fiu_fast_read_exec },
   298		{ wpcm_fiu_4ba_match, wpcm_fiu_4ba_exec },
   299		{ wpcm_fiu_rdid_match, wpcm_fiu_rdid_exec },
   300		{ wpcm_fiu_dummy_match, wpcm_fiu_dummy_exec },
   301	};
   302	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (324801 bytes)

Powered by blists - more mailing lists