linux-kernel - Re: [PATCH bpf-next] Documentation: bpf: escape underscore in BPF type name prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71f54713-4cce-9da8-e73d-9f5e78346971@gmail.com>
Date:   Sat, 5 Nov 2022 09:49:01 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Akira Yokosawa <akiyks@...il.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
        corbet@....net, daniel@...earbox.net, haoluo@...gle.com,
        john.fastabend@...il.com, jolsa@...nel.org, kpsingh@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        martin.lau@...ux.dev, memxor@...il.com, sdf@...gle.com,
        song@...nel.org, void@...ifault.com, yhs@...com
Subject: Re: [PATCH bpf-next] Documentation: bpf: escape underscore in BPF
 type name prefix

On 11/5/22 07:05, Akira Yokosawa wrote:
> Hi,
> 
> On Fri, 4 Nov 2022 16:11:10 -0700, Andrii Nakryiko wrote:
> [...]
>> Applied, thanks. But would the other similar case be problematic?
>>
>> $ rg 'bpf_\b'
>> bpf_design_QA.rst
>> 329:NOTE: BPF subsystem specially reserves the 'bpf_' prefix for type names, in
>> 331:avoid defining types with 'bpf_' prefix to not be broken in future
>> releases. In
>> 333:with 'bpf_' prefix.
>>
>> libbpf/libbpf_naming_convention.rst
>> 12:following prefixes: ``bpf_``, ``btf_``, ``libbpf_``, ``btf_dump_``,
>> 59:described above should have ``libbpf_`` prefix, e.g.
> 
> Those other cases are all inside double back quotes and
> construct "inline literal" strings. So they are fine.
> 
> Which means Bagas could have used the "inline literal" approach
> instead.
> 

Ah! I was oversighted (not seeing these other cases). Should I convert
fixed 'bpf_' to inline literals?

-- 
An old man doll... just what I always wanted! - Clara