linux-kernel - Re: [PATCH] x86/microcode/AMD: Attempt applying on every logical thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2XcRbaN9mDkWF9V@araj-dh-work>
Date:   Sat, 5 Nov 2022 03:45:09 +0000
From:   Ashok Raj <ashok_raj@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     X86 ML <x86@...nel.org>, Andrew Cooper <amc96@...f.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Ștefan Talpalaru <stefantalpalaru@...oo.com>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH] x86/microcode/AMD: Attempt applying on every logical
 thread

Hi Boris

On Thu, Aug 18, 2022 at 09:58:52AM +0000, Ashok Raj wrote:
> Hi Boris
> 
> On Wed, Aug 17, 2022 at 11:56:02PM +0200, Borislav Petkov wrote:
> > On Wed, Aug 17, 2022 at 08:58:07PM +0000, Ashok Raj wrote:
> > > For this specific patch in question, its not for testing though.. Its
> > > required for functional purposes?
> > 
> > From its commit message:
> > 
> > "However, there are microcode patches which do per-thread modification,
> > see Link tag below.
> > 
> 
> I did read the commit log. I was just stating the fact that reload isn't
> just for testing, for e.g. in this case its required for functional
> reasons.
> 
> if cpu_rev > ucode_rev, there is no need to reload microcode correct?
> There are a bunch of changes in the original post that seemed like it had
> nothing to do with force load on a sibling.
> 
> Completely untested, no commit log to spare you from fixing them :-)
> 
> Seemed like we were simply passing over each other with emails, thought
> I'll convey what I meant here via a patch. Hope this helps.
> 
> lemme know what you think.

I saw your original patch got tipbot notification, but I don't see the
patch in the staging area. 

I didn't see a followup to this, and wasn't sure if you fixed it some other
way.

I was cleaning up my mbox and want to be sure I didn't drop the ball. 

Cheers,
Ashok