linux-kernel - Re: [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 6 Nov 2022 10:10:59 +0000
From:   Mengqi Zhang (张梦琦) 
        <Mengqi.Zhang@...iatek.com>
To:     "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Wenbin Mei (梅文彬) 
        <Wenbin.Mei@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mengqi Zhang (张梦琦) 
        <Mengqi.Zhang@...iatek.com>,
        Chaotian Jing (井朝天) 
        <Chaotian.Jing@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock

On Wed, 2022-11-02 at 16:13 +0100, Ulf Hansson wrote:
> On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@...iatek.com
> > wrote:
> > 
> > Document the binding for crypto clock of the Inline Crypto Engine
> > of Mediatek SoCs.
> > 
> > Signed-off-by: Mengqi Zhang <mengqi.zhang@...iatek.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index d8e1e2e9adf2..f93d686e2911 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -57,6 +57,7 @@ properties:
> >        - description: peripheral bus clock gate (required for
> > MT8192).
> >        - description: AXI bus clock gate (required for MT8192).
> >        - description: AHB bus clock gate (required for MT8192).
> > +      - description: crypto clock used for data encrypt/decrypt
> > (optional).
> > 
> >    clock-names:
> >      minItems: 2
> > @@ -69,6 +70,7 @@ properties:
> >        - const: pclk_cg
> >        - const: axi_cg
> >        - const: ahb_cg
> > +      - const: crypto
> 
> Looks like minItems/maxItems for clocks needs to be updated too.
> 
> > 
> >    interrupts:
> >      description:
> > --
> > 2.25.1
> > 
> 
> Kind regards
> Uffe

Hi Uffe,

I just add crypto clock to mt8186/mt8188/mt8195, does not exceed the
minItems/maxItems.

I have re-sent my patch,

https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@mediatek.com/
Please help to review it.
Thanks!

Regards,
Mengqi