linux-kernel - Re: [PATCH] LoongArch: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5oPv0RnEE6p8K5rCsEEJyfE0QyG4sjBDtVkEQbSSyFEg@mail.gmail.com>
Date:   Sun, 6 Nov 2022 22:33:48 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     wangkailong@...i.cn
Cc:     kernel@...0n.name, zhangqing@...ngson.cn,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Fix unsigned comparison with less than zero

Queued for loongarch-fixes, thanks.

Huacai

On Sun, Nov 6, 2022 at 6:32 PM <wangkailong@...i.cn> wrote:
>
> Eliminate the following coccicheck warning:
>
> ./arch/loongarch/kernel/unwind_prologue.c:84:5-13: WARNING: Unsigned
> expression compared with zero: frame_ra < 0
>
> Signed-off-by: KaiLong Wang <wangkailong@...i.cn>
> ---
>  arch/loongarch/kernel/unwind_prologue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/unwind_prologue.c b/arch/loongarch/kernel/unwind_prologue.c
> index b206d9159205..58ccdbe7fa22 100644
> --- a/arch/loongarch/kernel/unwind_prologue.c
> +++ b/arch/loongarch/kernel/unwind_prologue.c
> @@ -43,7 +43,8 @@ static bool unwind_by_prologue(struct unwind_state *state)
>  {
>         struct stack_info *info = &state->stack_info;
>         union loongarch_instruction *ip, *ip_end;
> -       unsigned long frame_size = 0, frame_ra = -1;
> +       unsigned long frame_size = 0;
> +       long frame_ra = -1;
>         unsigned long size, offset, pc = state->pc;
>
>         if (state->sp >= info->end || state->sp < info->begin)
> --
> 2.25.1