[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2fQYGroZ7l3mSoe@rowland.harvard.edu>
Date: Sun, 6 Nov 2022 10:18:56 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-can@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 3/3] can: etas_es58x: report the firmware version
through ethtool
On Sun, Nov 06, 2022 at 09:47:05PM +0900, Vincent MAILHOL wrote:
> I have two questions:
>
> 1/ Can I still export and use usb_cache_string()? In other terms, does
> the first patch of this series still apply? This looks like the most
> convenient function to retrieve that custom string to me.
FWIW, that's okay with me.
> 2/ Is it a no-go to also populate ethtool_drvinfo::fw_version? Some
> users might look for the value in sysfs, while some might use ethtool.
> If the info is not available in ethtool, people might simply assume it
> is not available at all. So, I would like to provide both.
I don't see any reason not to do this.
Alan Stern
Powered by blists - more mailing lists