linux-kernel - Re: [PATCH v7] iio: temperature: Add driver support for Maxim MAX30208

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 6 Nov 2022 15:25:03 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>,
        lars@...afoo.de, llvm@...ts.linux.dev,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, jdelvare@...e.com, linux@...ck-us.net,
        linux-hwmon@...r.kernel.org, rajat.khandelwal@...el.com
Subject: Re: [PATCH v7] iio: temperature: Add driver support for Maxim
 MAX30208

On Fri, 4 Nov 2022 14:50:33 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Rajat,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on jic23-iio/togreg]
> [also build test WARNING on linus/master v6.1-rc3 next-20221104]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Rajat-Khandelwal/iio-temperature-Add-driver-support-for-Maxim-MAX30208/20221101-102308
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/20221101174409.316447-1-rajat.khandelwal%40linux.intel.com
> patch subject: [PATCH v7] iio: temperature: Add driver support for Maxim MAX30208
> config: riscv-randconfig-c006-20221103
> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install riscv cross compiling tool for clang build
>         # apt-get install binutils-riscv64-linux-gnu
>         # https://github.com/intel-lab-lkp/linux/commit/2375dabd39957ad8e80878c5604eda8a9f73932d
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Rajat-Khandelwal/iio-temperature-Add-driver-support-for-Maxim-MAX30208/20221101-102308
>         git checkout 2375dabd39957ad8e80878c5604eda8a9f73932d
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/block/ drivers/iio/temperature/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/iio/temperature/max30208.c:195:36: warning: unused variable 'max30208_acpi_match' [-Wunused-const-variable]  
>    static const struct acpi_device_id max30208_acpi_match[] = {
>                                       ^
>    1 warning generated.
> 
See review comments on v6 that said to drop the use of ACPI_PTR(). It's not worth
the fiddly handling to save a trivial amount of data.

Jonathan

> 
> vim +/max30208_acpi_match +195 drivers/iio/temperature/max30208.c
> 
>    194	
>  > 195	static const struct acpi_device_id max30208_acpi_match[] = {  
>    196		{ "MAX30208" },
>    197		{ }
>    198	};
>    199	MODULE_DEVICE_TABLE(acpi, max30208_acpi_match);
>    200	
>