[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a859e4c2-69b3-5531-2e96-4debe236e44a@wanadoo.fr>
Date: Sun, 6 Nov 2022 16:56:18 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: wangkailong@...i.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] recordmcount: Fix warning comparing pointer to 0
Le 06/11/2022 à 16:11, wangkailong@...i.cn a écrit :
> Fix the following coccicheck warning:
>
> scripts/recordmcount.c:142:13-14: WARNING comparing pointer to 0.
>
> Signed-off-by: KaiLong Wang <wangkailong@...i.cn>
> ---
> scripts/recordmcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index cce12e1971d8..750f5196608c 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
> static void * umalloc(size_t size)
> {
> void *const addr = malloc(size);
> - if (addr == 0) {
> + if (addr) {
Hi,
this change looks incorrect.
if (!addr)
maybe?
CJ
> fprintf(stderr, "malloc failed: %zu bytes\n", size);
> file_append_cleanup();
> mmap_cleanup();
Powered by blists - more mailing lists