linux-kernel - Re: [PATCH] EDAC: altera: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72d228fc27951a7ba9e607d9fc433b3c64a801e3.camel@perches.com>
Date:   Sun, 06 Nov 2022 08:26:04 -0800
From:   Joe Perches <joe@...ches.com>
To:     wangkailong@...i.cn, bp@...en8.de, mchehab@...nel.org,
        tony.luck@...el.com, james.morse@....com, rric@...nel.org
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: altera: Remove unnecessary print function
 dev_err()

On Sun, 2022-11-06 at 21:33 +0800, wangkailong@...i.cn wrote:
> Eliminate the follow coccicheck warning:
> 
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
[]
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
[]
> @@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  
>  	edac->sb_irq = platform_get_irq(pdev, 0);
>  	if (edac->sb_irq < 0) {
> -		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
>  		return edac->sb_irq;
>  	}

Should delete now unnecessary braces too

>  
> @@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  #else
>  	edac->db_irq = platform_get_irq(pdev, 1);
>  	if (edac->db_irq < 0) {
> -		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
>  		return edac->db_irq;
>  	}
>  	irq_set_chained_handler_and_data(edac->db_irq,