linux-kernel - Re: [RFC PATCH] acpi: make remove callback of acpi driver void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221106165422.nzfw36oj5q2splnc@pengutronix.de>
Date:   Sun, 6 Nov 2022 17:54:22 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Dawei Li <set_pte_at@...look.com>
Cc:     rafael@...nel.org, gregkh@...uxfoundation.org,
        dvhart@...radead.org, andy@...radead.org, lenb@...nel.org,
        arnd@...db.de, peterhuewe@....de, kys@...rosoft.com,
        kronos.it@...il.com, dmitry.torokhov@...il.com,
        bleung@...omium.org, sujith.thomas@...el.com, vithampi@...are.com,
        lee@...nel.org, wim@...ux-watchdog.org, jgross@...e.com,
        davem@...emloft.net, linux-acpi@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] acpi: make remove callback of acpi driver void

Hello,

On Sun, Nov 06, 2022 at 10:57:53PM +0800, Dawei Li wrote:
> For bus-based driver, device removal is implemented as:
> 1 device_remove()->
> 2   bus->remove()->
> 3     driver->remove()
> 
> Driver core needs _no_ inform from callee(bus driver) about the
> result of remove callback. In that case,
> commit <fc7a6209d571> ("bus: Make remove callback return void")
> forces struct bus_type::remove() be void-returned.
> 
> Now we have the situation that both 1 & 2 of calling chain are
> void-returned, so it does _not_ make much sense for 3(driver->remove)
> to return non-void to its caller.
> 
> So the basic idea behind this change is making remove() callback of
> any bus-based driver to be void-returned.
> 
> This change itself, is for device drivers based on acpi-bus.
> 
> Signed-off-by: Dawei Li <set_pte_at@...look.com>

Nice,

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

It might be worth to point out that the callers of the remove callback
(i.e. acpi_device_probe and acpi_device_remove) silently ignore the
return value already today and even since before commit fc7a6209d571
("bus: Make remove callback return void").

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)