[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ba17991a-0e66-11f4-1480-2663e71c70c4@csgroup.eu>
Date: Sun, 6 Nov 2022 17:13:35 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
"wangkailong@...i.cn" <wangkailong@...i.cn>,
"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
"mpe@...erman.id.au" <mpe@...erman.id.au>
CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] macintosh: Fix warning comparing pointer to 0
Le 06/11/2022 à 17:08, Christophe JAILLET a écrit :
> Le 06/11/2022 à 16:18, wangkailong@...i.cn a écrit :
>> Fix the following coccicheck warning:
>>
>> drivers/macintosh/macio-adb.c:103:13-14: WARNING comparing pointer to 0.
>>
>> Signed-off-by: KaiLong Wang <wangkailong@...i.cn>
We already have such patches awaiting for application, see
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=83647
Please check patchwork before submitting such fixes as they may already
exist.
Thanks
Christophe
>> ---
>> drivers/macintosh/macio-adb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/macintosh/macio-adb.c
>> b/drivers/macintosh/macio-adb.c
>> index 9b63bd2551c6..1c1c375a817d 100644
>> --- a/drivers/macintosh/macio-adb.c
>> +++ b/drivers/macintosh/macio-adb.c
>> @@ -100,7 +100,7 @@ int macio_init(void)
>> unsigned int irq;
>> adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0");
>> - if (adbs == 0)
>> + if (adbs)
>
> Hi
> no, this should be "if (!adbs)"
>
> CJ
>
>> return -ENXIO;
>> if (of_address_to_resource(adbs, 0, &r)) {
>
Powered by blists - more mailing lists