linux-kernel - Re: [PATCH] hwmon: Include <linux/kstrtox.h> when appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221106171601.GB105056@roeck-us.net>
Date:   Sun, 6 Nov 2022 09:16:01 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Jean Delvare <jdelvare@...e.com>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        Henrik Rydberg <rydberg@...math.org>,
        George Joseph <george.joseph@...rview5.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Nuno Sá <nuno.sa@...log.com>,
        Juerg Haefliger <juergh@...ton.me>,
        Steve Glendinning <steve.glendinning@...well.net>,
        Riku Voipio <riku.voipio@....fi>,
        Huang Rui <ray.huang@....com>,
        Tim Harvey <tharvey@...eworks.com>,
        Guillaume Ligneul <guillaume.ligneul@...il.com>,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        Jim Cromie <jim.cromie@...il.com>,
        Roger Lucas <vt8231@...denengine.co.uk>,
        Marc Hulsman <m.hulsman@...elft.nl>,
        Rudolf Marek <r.marek@...embler.cz>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH] hwmon: Include <linux/kstrtox.h> when appropriate

On Sun, Nov 06, 2022 at 11:31:27AM +0100, Christophe JAILLET wrote:
> The kstrto<something>() functions have been moved from kernel.h to
> kstrtox.h.
> 
> So, include the latter directly in the appropriate files.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> The goal of this patch is to eventually remove <linux/kernel.h> from
> <linux/watchdog.h>.
> 
> This patch is needed to avoid indirect inclusion, via <linux/watchdog.h>,
> in fschmd.c, ftsteutates.c and w83793.c.
> 
> 
> Maybe, just including <linux/kstrtox.h> in <linux/hwmon.h> would also do
> the job. It is likely that this file is included in all hwmon's drivers.
> Let me know if this less intrusive approach is preferred.

Include it from <linux/hwmon-sysfs.h>. This should cover almost all
drivers needing it. The remaining drivers (if there are any) should
include it directly. Almost all drivers registering the hwmon device
with [devm_]hwmon_device_register_with_info() do not need the include,
but (almost) all drivers registering with an older API will need it.
Those drivers will also include <linux/hwmon-sysfs.h>.

Thanks,
Guenter