linux-kernel - Re: [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2f079jOra55IGgr@mail.local>
Date:   Sun, 6 Nov 2022 18:54:55 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        kernel test robot <lkp@...el.com>, a.zummo@...ertech.it,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms

Hello, this doesn't need to be backported unless you also backport
those:
0782b66ed2fb rtc: cmos: Fix wake alarm breakage
4919d3eb2ec0 rtc: cmos: Fix event handler registration ordering issue
6492fed7d8c9 rtc: rtc-cmos: Do not check ACPI_FADT_LOW_POWER_S0


On 06/11/2022 12:07:29-0500, Sasha Levin wrote:
> From: Alexandre Belloni <alexandre.belloni@...tlin.com>
> 
> [ Upstream commit db4e955ae333567dea02822624106c0b96a2f84f ]
> 
> Now that rtc_wake_setup is called outside of cmos_wake_setup, it also need
> to be defined on non-ACPI platforms.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/r/20221018203512.2532407-1-alexandre.belloni@bootlin.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/rtc/rtc-cmos.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 1dbd8419df7d..2c3881bdf9bb 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1113,6 +1113,9 @@ static void cmos_check_acpi_rtc_status(struct device *dev,
>  {
>  }
>  
> +static void rtc_wake_setup(struct device *dev)
> +{
> +}
>  #endif
>  
>  #ifdef	CONFIG_PNP
> -- 
> 2.35.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com