linux-kernel - Re: [tip: x86/urgent] x86/tdx: Prepare for using "INFO" call for a second purpose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2gP+AT1XdapImV4@zn.tnic>
Date:   Sun, 6 Nov 2022 20:50:16 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        x86@...nel.org
Subject: Re: [tip: x86/urgent] x86/tdx: Prepare for using "INFO" call for a
 second purpose

On Sun, Nov 06, 2022 at 09:02:27AM -0800, Dave Hansen wrote:
> It's fine for now, except that the naming on this:
> 
> -	tdx_parse_tdinfo(&cc_mask);
> +	cc_mask = tdx_parse_tdinfo();
> 
> is a bit funky since tdx_parse_tdinfo() is doing a couple of things

Yeah, that was the next thing that was bothering me.

> and will need to return a second item shortly.

Well, then rename this one back to get_cc_mask() and have a new function
return the second item?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette