linux-kernel - Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiD3VWYqgO7JLqRCJvYHiO5RicGAERH1dWQ2pDqnXDy6g@mail.gmail.com>
Date:   Sun, 6 Nov 2022 12:51:46 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

Thanks, this looks reasonable.

On Sat, Nov 5, 2022 at 10:46 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> The coccinelle script:
>
> @@
> expression E;
> identifier ptr, timer, rfield, slab;

I think Julia suggested making 'ptr' be an expression too, and I think
she's right. Probably 'slab' should be too - there's no reason to
limit it to just one identifier.

>   ... when strict
>       when != ptr->timer.function = E;

I suspect any "ptr->timer" access anywhere between the
del_timer_sync() and the freeing should disable things.

Although hopefully there aren't any other odd cases than that one
"clear timer function by hand" one.

                   Linus