linux-kernel - Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whO5PXEzWwf=4=fvdqim6cGTczVoN4KJ5H+dabHo-OTHw@mail.gmail.com>
Date:   Sun, 6 Nov 2022 14:40:14 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

On Sun, Nov 6, 2022 at 1:52 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> I can update the change log to include:

Yup, full running instructions for coccinelle patches is probably a good idea.

I've done them semi-occasionally, but it's rare enough that I always
have to look it up anyway, and I suspect many others have never done
it, so having it in the commit message is probably a good idea.

>       when != ptr->timer.function = E;

I do think that you should just remove that E expression and the
"function = E" part.

Really, _any_ use of the timer after the timer delete makes it questionable,

It doesn't change the patch in my testing, but I think it's silly to
have that very specific pattern, when the more general case of "hey,
if you use the timer after deleting it, it's not obvious that it
should be a shutdown any more" just is more sensible anyway.

                 Linus