linux-kernel - Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221106224802.suut4pni6u2c27tv@yadavpratyush.com>
Date:   Sun, 6 Nov 2022 23:48:02 +0100
From:   Pratyush Yadav <pratyush@...nel.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Michael Walle <michael@...le.cc>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw()
 kerneldoc comment

On 01/11/22 05:29PM, Jonathan Neuschäfer wrote:
> It doesn't make sense to put "set" on its own line like that.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>

Acked-by: Pratyush Yadav <pratyush@...nel.org>

> ---
>  drivers/mtd/spi-nor/sfdp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index 2257f1b4c2e2d..3e0bb383ab8e2 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -135,8 +135,7 @@ struct sfdp_4bait {
>  /**
>   * spi_nor_read_raw() - raw read of serial flash memory. read_opcode,
>   *			addr_nbytes and read_dummy members of the struct spi_nor
> - *			should be previously
> - * set.
> + *			should be previously set.
>   * @nor:	pointer to a 'struct spi_nor'
>   * @addr:	offset in the serial flash memory
>   * @len:	number of bytes to read
> --
> 2.35.1
> 

-- 
Regards,
Pratyush Yadav