linux-kernel - Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d43885-dc99-f2a-fbc9-1e8ccad39ed7@inria.fr>
Date:   Mon, 7 Nov 2022 07:09:43 +0800 (+08)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
cc:     Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to
 timer_shutdown*()



On Sun, 6 Nov 2022, Linus Torvalds wrote:

> On Sun, Nov 6, 2022 at 1:10 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> >   ... when strict
> >       when != ptr->timer.function = E;
>
> .. and I tried this with just 'ptr->timer', and it doesn't seem to
> make any difference, so apparently that NULL pointer initialization
> was the only case.

OK, good to know.

julia

>
> And then - like you and Guenter - I went through the patch manually to
> look for anything that looked odd, and didn't find anything.
>
> So yes, I'm happy with this. It looks like a very reasonable "let's
> handle the scripted trivial cases automatically", and then anything
> more complicated can be left for 6.2.
>
> And with that cocci script (and how to run it), people can see what
> the script was, and even run it themselves to verify, and that just
> makes me feel all warm and fuzzy about it.
>
>                  Linus
>