linux-kernel - Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221107162309.54192-1-miquel.raynal@bootlin.com>
Date:   Mon,  7 Nov 2022 17:23:09 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        noreply@...erman.id.au
Subject: Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()

On Thu, 2022-10-27 at 13:10:27 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
> 
>     drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
>       380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
>           |             ^~~~~~~~~~~~~~~~~~
> 
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
> 
> Reported-by: noreply@...erman.id.au
> Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel