linux-kernel - RE: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYWPR01MB8775F35BAFDB90658F90D5A0C23C9@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Date:   Mon, 7 Nov 2022 16:46:25 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Magnus Damm <magnus.damm@...il.com>,
        Biju Das <biju.das.jz@...renesas.com>,
        Wolfram Sang <wsa@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo@...ndi.org>
Subject: RE: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific
 string

Hi Krzysztof and Geert,

Thanks for your feedback, I'll send a new version of the bindings and DT
patches to improve the changelog.

Thanks,
Fab

> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 04 November 2022 12:55
> Subject: Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific
> string
> 
> On 04/11/2022 04:55, Geert Uytterhoeven wrote:
> > Hi Krzysztof,
> >
> > On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@...aro.org> wrote:
> >> On 03/11/2022 19:06, Fabrizio Castro wrote:
> >>> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> >>>
> >>> renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> >>> changing this doesn't cause any harm.
> >>
> >> And what about other users of DTS? One chosen driver implementation
> >> might not be enough...
> >>
> >>>
> >>> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C
> controller")
> >>
> >> You need to explain the bug - where is the issue, how it affects users.
> >> Otherwise it is not a bug and there is nothing to fix.
> >
> > Yep.
> >
> >     The preferred form is "<vendor>,<family>-<module>", blah blah ...
> >
> >>> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> index c46378efc123..92e899905ef8 100644
> >>> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> @@ -16,7 +16,7 @@ properties:
> >>>    compatible:
> >>>      items:
> >>>        - enum:
> >>> -          - renesas,i2c-r9a09g011  # RZ/V2M
> >>> +          - renesas,r9a09g011-i2c  # RZ/V2M
> >>
> >> No.
> >>
> >> Deprecate instead old compatible. There are already users of it, at
> >> least in kernel. Not sure about other OS/bootloaders/firmwares.
> >
> > As stated in the cover letter:
> >
> >     Since it's early days for r9a09g011.dtsi, and compatible
> >     renesas,i2c-r9a09g011 isn't being actively used at the moment,
> >     I think it's safe to change to make compatible strings less
> >     confusing.
> >
> > The bindings entered in v6.0.
> > The first user in the kernel is not yet in a released kernel, it will
> > be in v6.1. So it can still be fixed in v6.1...
> > Even if we don't fix it before v6.2, I don't think there is much harm in
> > making this change.
> >
> 
> ABI break reasons should be explained in the commit because cover letter
> does not get merged.
> 
> Best regards,
> Krzysztof