linux-kernel - Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com>
Date:   Mon, 7 Nov 2022 09:31:55 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Pierre Gondois <pierre.gondois@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        William Zhang <william.zhang@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom

(way too many recipients, gmail's SMTP server would not allow me to 
respond unless I moved most people to BCC now done).

On 11/7/22 07:56, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
> 
> Update the Device Trees accordingly.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
> Acked-by: William Zhang <william.zhang@...adcom.com>

This looks fine, but incomplete, you seem to have missed:

- adding 'cache-unified' to all of the cache nodes modified in this 
patch set that did not have one already

- bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi, 
bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi

Thanks
-- 
Florian