linux-kernel - Re: [PATCH v2] extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50130fa2-e15a-a043-94c8-002ac0817135@denx.de>
Date:   Mon, 7 Nov 2022 18:58:15 +0100
From:   Marek Vasut <marex@...x.de>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Yassine Oudjana <yassine.oudjana@...il.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yassine Oudjana <y.oudjana@...tonmail.com>
Subject: Re: [PATCH v2] extcon: usbc-tusb320: Call the Type-C IRQ handler only
 if a port is registered

On 11/7/22 17:28, Heikki Krogerus wrote:
> On Mon, Nov 07, 2022 at 06:33:17PM +0300, Yassine Oudjana wrote:
>> From: Yassine Oudjana <y.oudjana@...tonmail.com>
>>
>> Commit bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> added an optional Type-C interface to the driver but missed to check
>> if it is in use when calling the IRQ handler. This causes an oops on
>> devices currently using the old extcon interface. Check if a Type-C
>> port is registered before calling the Type-C IRQ handler.
>>
>> Fixes: bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
>> Reviewed-by: Marek Vasut <marex@...x.de>
> 
> Looks good to me. FWIW:
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Likewise, looks good. You already have my RB. Thanks !