linux-kernel - Re: [PATCH] perf print-events: Remove redundant comparison with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cjm+_h3C6=0UYR=pSiB4m8fEt3WUy-tkLos_yYu4bFWsA@mail.gmail.com>
Date:   Mon, 7 Nov 2022 12:59:00 -0800
From:   Namhyung Kim <namhyung@...nel.org>
To:     Kang Minchul <tegongkang@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf print-events: Remove redundant comparison with zero

Hi Minchul,

On Sat, Nov 5, 2022 at 6:59 AM Kang Minchul <tegongkang@...il.com> wrote:
>
> Since variable npmus is unsigned int, comparing with 0 is unnecessary.
>
> Signed-off-by: Kang Minchul <tegongkang@...il.com>
> ---
>  tools/perf/util/print-events.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c
> index c4d5d87fae2f..6df947df1c0f 100644
> --- a/tools/perf/util/print-events.c
> +++ b/tools/perf/util/print-events.c
> @@ -311,10 +311,8 @@ int print_hwcache_events(const char *event_glob, bool name_only)
>                                 if ((hybrid_supported == 0) ||
>                                     (hybrid_supported == npmus)) {
>                                         evt_list[evt_i] = strdup(name);
> -                                       if (npmus > 0) {
> -                                               for (j = 0; j < npmus; j++)
> -                                                       zfree(&evt_pmus[j]);
> -                                       }
> +                                       for (j = 0; j < npmus; j++)
> +                                               zfree(&evt_pmus[j]);

You can still have 0 npmus, but then the for loop will not be executed.  So,

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung


>                                 } else {
>                                         for (j = 0; j < hybrid_supported; j++) {
>                                                 evt_list[evt_i++] = evt_pmus[j];
> --
> 2.34.1
>