[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a1c8aa27-5c67-6cfc-39fd-15157c91bedb@quicinc.com>
Date: Mon, 7 Nov 2022 15:14:33 -0800
From: Melody Olvera <quic_molvera@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC: Robert Marko <robimarko@...il.com>,
Guru Das Srinagesh <quic_gurus@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000
compatibles
On 10/27/2022 8:24 AM, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>> ---
>> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index be1b5746eddb..5352181aa393 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -38,6 +38,7 @@ properties:
>> - qcom,scm-msm8994
>> - qcom,scm-msm8996
>> - qcom,scm-msm8998
>> + - qcom,scm-qdu1000
>> - qcom,scm-sc7180
>> - qcom,scm-sc7280
>> - qcom,scm-sc8280xp
>> @@ -81,6 +82,20 @@ properties:
>> description: TCSR hardware block
>>
>> allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,scm-qdu1000
>> + then:
>> + properties:
>> + '#reset-cells':
>> + maxItems: 1
> This is wrong... how can you have here more items?
Being removed anyways.
>
>> + clocks: false
>> + clock-names: false
>> +
>> + required:
>> + - '#reset-cells'
> Missing blank line.
Ack.
Thanks,
Melody
>
>> - if:
>> properties:
>> compatible:
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists