linux-kernel - Re: [for-linus][PATCH 4/5] timers: Add timer_shutdown_sync() and timer_shutdown() to be called before freeing timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y1sm8h1o.ffs@tglx>
Date:   Tue, 08 Nov 2022 00:45:55 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>
Subject: Re: [for-linus][PATCH 4/5] timers: Add timer_shutdown_sync() and
 timer_shutdown() to be called before freeing timers

On Mon, Nov 07 2022 at 05:43, Steven Rostedt wrote:
> On November 7, 2022 3:15:43 AM PST, Thomas Gleixner <tglx@...utronix.de> wrote:
>>On Mon, Nov 07 2022 at 11:45, Thomas Gleixner wrote:
>>> On Sun, Nov 06 2022 at 18:30, Steven Rostedt wrote:
>>>>
>>>> Link: https://lore.kernel.org/all/87pmlrkgi3.ffs@tglx/
>>>> Link: https://lkml.kernel.org/r/20221106212702.363575800@goodmis.org
>>>> Link: https://lore.kernel.org/all/20221105060024.598488967@goodmis.org/
>>>>
>>>> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>>> Cc: Stephen Boyd <sboyd@...nel.org>
>>>> Cc: Anna-Maria Gleixner <anna-maria@...utronix.de>
>>>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>>>> Cc: Julia Lawall <Julia.Lawall@...ia.fr>
>>>> Tested-by: Guenter Roeck <linux@...ck-us.net>
>>>> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
>>>
>>> And please follow the guidelines of the tip tree for changelogs and tags.
>>>
>>> I'll just grab it from the list and let my scripts run over it.
>>
>>Duh. This thing is unreviewable.
>>
>>Can you please split it up into pieces which are digestable?
>
> Sure, but I'm traveling this week and may not get to it until Friday.

That's fine as I think this whole approach is wrong to begin with.

We are not doing a tree wide change at rc4 just to scratch an itch which
is there for ages and has been debated for months.

Q: Did you try a merge of the result against -next?
A: Definitely not.

The proper approach is to provide all the infrastructure, i.e. the new
interfaces and merge them during the next merge window. Right before rc1
provide a script or a script converted tree to Linus which switches the
tree over to the new world order.

How long have you been around doing kernel development and how much fuzz
do you make about even trivial changes to ftrace?

Thanks,

        tglx