linux-kernel - Re: [PATCH v4 4/7] arm64: dts: mediatek: mt8516: Fix the watchdog node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6aa2fe039226d3fc94d92df5e1913515e0e564e.camel@mediatek.com>
Date:   Mon, 7 Nov 2022 01:39:51 +0000
From:   Allen-KH Cheng (程冠勳) 
        <Allen-KH.Cheng@...iatek.com>
To:     "nfraprado@...labora.com" <nfraprado@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v4 4/7] arm64: dts: mediatek: mt8516: Fix the watchdog
 node name

Hi Nícolas,

On Fri, 2022-11-04 at 10:32 -0400, Nícolas F. R. A. Prado wrote:
> On Fri, Nov 04, 2022 at 10:06:58AM +0800, Allen-KH Cheng wrote:
> > The proper name is 'watchdog', not 'toprgu'.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > index d1b67c82d761..fff59dc1b4d7 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > @@ -202,7 +202,7 @@
> >  			#clock-cells = <1>;
> >  		};
> >  
> > -		toprgu: toprgu@...07000 {
> > +		toprgu: watchdog@...07000 {
> 
> I think you missed my comment about renaming the label as well on the
> previous
> version.
> 

Yep, I may have misunderstood.

I will remove the label.

Thanks,
Allen

> >  			compatible = "mediatek,mt8516-wdt",
> >  				     "mediatek,mt6589-wdt";
> >  			reg = <0 0x10007000 0 0x1000>;
> > -- 
> > 2.18.0
> >