linux-kernel - RE: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 07 Nov 2022 09:04:01 +0900
From:   CHANHO PARK <chanho61.park@...sung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Inbaraj E <inbaraj.e@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        "tomasz.figa@...il.com" <tomasz.figa@...il.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        CHANHO PARK <chanho61.park@...sung.com>
CC:     "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        PANKAJ KUMAR DUBEY <pankaj.dubey@...sung.com>
Subject: RE: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock

> > Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> >
> > This fixes make dtbs_check warning as shown below:
> >
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> controller@...40000:
> > clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
> > /home/inbaraj/mainline/linux/Documentation/devicetree/
> > bindings/clock/samsung,exynosautov9-clock.yaml
> 
> I don't understand:
> 1. Why bindings are wrong not DTSI?
> 2. What is "gout"? "dout" had a meaning as clock divider output.

"gout" is output of a gate clock, AFAIK.
Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".

> 
> >
> > Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for
> > cmu_fsys0/1")
> > Signed-off-by: Inbaraj <inbaraj.e@...sung.com>

Reviewed-by: Chanho Park <chanho61.park@...sung.com>

Best Regards,
Chanho Park