linux-kernel - Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2jJpT5//xBUOQMq@kroah.com>
Date:   Mon, 7 Nov 2022 10:02:29 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Slark Xiao <slark_xiao@....com>
Cc:     mani@...nel.org, loic.poulain@...aro.org, dnlplm@...il.com,
        yonglin.tan@...look.com, fabio.porcedda@...il.com,
        mhi@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs

On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote:
> To make code neat and for convenience purpose, use macro for
> some VIDs. These macros are supposed to be added to pci_ids.h.

No, they are not supposed to be added there at all.

And they are not a "macro", it is a "#define".

> But until the macros are used in multiple places, it is not
> recommended. So adding it locally for now.

Again, these are not macros

thanks,

greg k-h