linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2jKyyZqAssNiRNB@google.com>
Date:   Mon, 7 Nov 2022 09:07:23 +0000
From:   Lee Jones <lee@...nel.org>
To:     Luca Weiss <luca@...tu.xyz>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        afd@...com, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more
 types

On Mon, 31 Oct 2022, Luca Weiss wrote:

> * 'adc@' is either spmi-iadc or spmi-vadc
> * 'charger@' is either pm8941-charger or pm8941-coincell
> * 'usb-vbus-regulator@' is usb-vbus-regulator
> * 'vibrator@' is now in yaml format, so add it
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
> Changes since v1:
> * Change dcdc@ to usb-vbus-regulator@
> * Link to pm8xxx-vib.yaml
> 
>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml  | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)

I don't see the other 2 patches.

Is this okay to take on its own?

> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 777f2da52f1e..cf10d62ace54 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -105,7 +105,9 @@ properties:
>  patternProperties:
>    "^adc@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
> +    oneOf:
> +      - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
> +      - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
>  
>    "^adc-tm@[0-9a-f]+$":
>      type: object
> @@ -115,6 +117,12 @@ patternProperties:
>      type: object
>      additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>  
> +  "^charger@[0-9a-f]+$":
> +    type: object
> +    oneOf:
> +      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> +      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
>    "extcon@[0-9a-f]+$":
>      type: object
>      $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> @@ -135,9 +143,13 @@ patternProperties:
>      type: object
>      $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
>  
> +  "^usb-vbus-regulator@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
> +
>    "^vibrator@[0-9a-f]+$":
>      type: object
> -    additionalProperties: true # FIXME qcom,pm8916-vib binding not converted yet
> +    $ref: /schemas/input/qcom,pm8xxx-vib.yaml#
>  
>    "^mpps@[0-9a-f]+$":
>      type: object

-- 
Lee Jones [李琼斯]