[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202211071704.FElpkLk8-lkp@intel.com>
Date: Mon, 7 Nov 2022 17:35:56 +0800
From: kernel test robot <lkp@...el.com>
To: Nayna Jain <nayna@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org,
linux-fsdevel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-efi@...r.kernel.org,
linux-security-module <linux-security-module@...r.kernel.org>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michael Ellerman <mpe@...erman.id.au>, npiggin@...il.com,
christophe.leroy@...roup.eu, Dov Murik <dovmurik@...ux.ibm.com>,
George Wilson <gcwilson@...ux.ibm.com>,
Matthew Garrett <mjg59@...f.ucam.org>,
Dave Hansen <dave.hansen@...el.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Russell Currey <ruscur@...sell.cc>,
Andrew Donnellan <ajd@...ux.ibm.com>,
Stefan Berger <stefanb@...ux.ibm.com>,
Nayna Jain <nayna@...ux.ibm.com>
Subject: Re: [PATCH 2/4] fs: define a firmware security filesystem named
fwsecurityfs
Hi Nayna,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master v6.1-rc4 next-20221104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nayna-Jain/powerpc-pseries-expose-firmware-security-variables-via-filesystem/20221107-053231
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20221106210744.603240-3-nayna%40linux.ibm.com
patch subject: [PATCH 2/4] fs: define a firmware security filesystem named fwsecurityfs
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/a0d08494d55c4b958e23479a4eb55c144b719d95
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Nayna-Jain/powerpc-pseries-expose-firmware-security-variables-via-filesystem/20221107-053231
git checkout a0d08494d55c4b958e23479a4eb55c144b719d95
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
fs/fwsecurityfs/super.c: In function 'fwsecurityfs_init':
>> fs/fwsecurityfs/super.c:248:14: error: implicit declaration of function 'sysfs_create_mount_point' [-Werror=implicit-function-declaration]
248 | rc = sysfs_create_mount_point(firmware_kobj, "security");
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> fs/fwsecurityfs/super.c:248:39: error: 'firmware_kobj' undeclared (first use in this function)
248 | rc = sysfs_create_mount_point(firmware_kobj, "security");
| ^~~~~~~~~~~~~
fs/fwsecurityfs/super.c:248:39: note: each undeclared identifier is reported only once for each function it appears in
>> fs/fwsecurityfs/super.c:254:17: error: implicit declaration of function 'sysfs_remove_mount_point' [-Werror=implicit-function-declaration]
254 | sysfs_remove_mount_point(firmware_kobj, "security");
| ^~~~~~~~~~~~~~~~~~~~~~~~
fs/fwsecurityfs/super.c: At top level:
>> fs/fwsecurityfs/super.c:261:20: error: expected declaration specifiers or '...' before string constant
261 | MODULE_DESCRIPTION("Firmware Security Filesystem");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/fwsecurityfs/super.c:262:15: error: expected declaration specifiers or '...' before string constant
262 | MODULE_AUTHOR("Nayna Jain");
| ^~~~~~~~~~~~
fs/fwsecurityfs/super.c:263:16: error: expected declaration specifiers or '...' before string constant
263 | MODULE_LICENSE("GPL");
| ^~~~~
cc1: some warnings being treated as errors
vim +/sysfs_create_mount_point +248 fs/fwsecurityfs/super.c
243
244 static int __init fwsecurityfs_init(void)
245 {
246 int rc;
247
> 248 rc = sysfs_create_mount_point(firmware_kobj, "security");
249 if (rc)
250 return rc;
251
252 rc = register_filesystem(&fs_type);
253 if (rc) {
> 254 sysfs_remove_mount_point(firmware_kobj, "security");
255 return rc;
256 }
257
258 return 0;
259 }
260 core_initcall(fwsecurityfs_init);
> 261 MODULE_DESCRIPTION("Firmware Security Filesystem");
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (291899 bytes)
Powered by blists - more mailing lists