linux-kernel - Re: [PATCH v11 5/5] arm64: dts: qcom: sc7280: sort out the "Status" to last property with sc7280-herobrine-audio-rt5682.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 11:02:38 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     dianders@...omium.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v11 5/5] arm64: dts: qcom: sc7280: sort out the "Status"
 to last property with sc7280-herobrine-audio-rt5682.dtsi



On 07/11/2022 10:43, Sheng-Liang Pan wrote:
> To keep diffs clean, sort out "Status" to last property.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
> 
> Changes in v11:
> - sort out the "Status" property with sc7280-herobrine-audio-rt5682.dtsi
> 
>   .../dts/qcom/sc7280-herobrine-audio-rt5682.dtsi    | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index 2dbdeeb29ecec..fc7a659dfe4ae 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -13,14 +13,14 @@ sound: sound {
>   		compatible = "google,sc7280-herobrine";
>   		model = "sc7280-rt5682-max98360a-1mic";
>   
> -		status = "okay";
> -		audio-routing =
> -			"Headphone Jack", "HPOL",
> -			"Headphone Jack", "HPOR";
> +		audio-routing = "Headphone Jack", "HPOL",
> +				"Headphone Jack", "HPOR";
>   
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> +		status = "okay";
> +
>   		dai-link@0 {
>   			link-name = "MAX98360";
>   			reg = <0>;
> @@ -50,8 +50,8 @@ codec {
>   };
>   
>   hp_i2c: &i2c2 {
> -	status = "okay";
>   	clock-frequency = <400000>;
> +	status = "okay";
>   
>   	alc5682: codec@1a {
>   		compatible = "realtek,rt5682s";
> @@ -75,8 +75,6 @@ alc5682: codec@1a {
>   };
>   
>   &lpass_cpu {
> -	status = "okay";
> -
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>, <&mi2s0_sclk>, <&mi2s0_ws>,
>   			<&mi2s1_data0>, <&mi2s1_sclk>, <&mi2s1_ws>;
> @@ -84,6 +82,8 @@ &lpass_cpu {
>   	#address-cells = <1>;
>   	#size-cells = <0>;
>   
> +	status = "okay";
> +
>   	dai-link@0 {
>   		reg = <MI2S_PRIMARY>;
>   		qcom,playback-sd-lines = <1>;