linux-kernel - Re: [PATCH v8 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  7 Nov 2022 11:21:34 +0100
From:   Peter Newman <peternewman@...gle.com>
To:     babu.moger@....com
Cc:     akpm@...ux-foundation.org, bagasdotme@...il.com, bp@...en8.de,
        chang.seok.bae@...el.com, corbet@....net,
        damien.lemoal@...nsource.wdc.com, daniel.sneddon@...ux.intel.com,
        dave.hansen@...ux.intel.com, eranian@...gle.com,
        fenghua.yu@...el.com, hpa@...or.com, james.morse@....com,
        jmattson@...gle.com, jpoimboe@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, paulmck@...nel.org,
        pawan.kumar.gupta@...ux.intel.com, pbonzini@...hat.com,
        peterz@...radead.org, quic_neeraju@...cinc.com,
        rdunlap@...radead.org, reinette.chatre@...el.com,
        sandipan.das@....com, songmuchun@...edance.com, tglx@...utronix.de,
        tony.luck@...el.com, x86@...nel.org
Subject: Re: [PATCH v8 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config

Hi Babu,

On Fri, Nov 04, 2022 at 03:01:09PM -0500, Babu Moger wrote:
> +	/*
> +	 * When an Event Configuration is changed, the bandwidth counters
> +	 * for all RMIDs and Events will be cleared by the hardware. The
> +	 * hardware also sets MSR_IA32_QM_CTR.Unavailable (bit 62) for
> +	 * every RMID on the next read to any event for every RMID.
> +	 * Subsequent reads will have MSR_IA32_QM_CTR.Unavailable (bit 62)
> +	 * cleared while it is tracked by the hardware. Clear the
> +	 * mbm_local and mbm_total counts for all the RMIDs.
> +	 */
> +	memset(d->mbm_local, 0, sizeof(struct mbm_state) * r->num_rmid);
> +	memset(d->mbm_total, 0, sizeof(struct mbm_state) * r->num_rmid);

Looking around, I can't find a reader for mbm_total anymore. It looks
like the last place it was used went away in James's recent change:

https://lore.kernel.org/all/20220902154829.30399-19-james.morse@arm.com

Are we supposed to be clearing arch_mbm_total now?

Thanks!
-Peter