linux-kernel - Re: [PATCH 0/3] Migrate i8255 GPIO drivers to regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2jfzKZkcEcQTdH5@smile.fi.intel.com>
Date:   Mon, 7 Nov 2022 12:37:00 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Migrate i8255 GPIO drivers to regmap API

On Thu, Nov 03, 2022 at 07:20:46AM -0400, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver.
> 
> Precursor patches are provided for 104-dio-48e and 104-idi-48 to migrate
> their respective device-specific registers first in order to simplify
> the subsequent patch migrating the i8255 library and its dependents.
> 
> The struct i8255 control_state member serves as a cache of the i8255
> device's control register. Does the regmap API support caching such that
> we won't need to manually update a control_state member?

Yes, regmap supports caching and IIRC it's opt-out.

> William Breathitt Gray (3):
>   gpio: 104-dio-48e: Migrate to regmap API
>   gpio: 104-idi-48: Migrate to regmap API
>   gpio: i8255: Migrate to regmap API
> 
>  drivers/gpio/gpio-104-dio-48e.c | 200 +++++++++++++++++++----------
>  drivers/gpio/gpio-104-idi-48.c  | 110 +++++++++++-----
>  drivers/gpio/gpio-gpio-mm.c     |  97 ++++++++++----
>  drivers/gpio/gpio-i8255.c       | 218 +++++++++++++++++++++-----------
>  drivers/gpio/gpio-i8255.h       |  54 ++++----
>  5 files changed, 451 insertions(+), 228 deletions(-)
> 
> 
> base-commit: b8b80348c57b360019071e17380298619c5d8066
> -- 
> 2.37.3
> 

-- 
With Best Regards,
Andy Shevchenko