linux-kernel - Re: [PATCH v3 04/12] drm/mediatek: extract common functions from the mtk hdmi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8e05f55-635c-f63c-9624-f8ccadcd1add@collabora.com>
Date:   Mon, 7 Nov 2022 12:09:25 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Guillaume Ranquet <granquet@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Jitao shi <jitao.shi@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Vinod Koul <vkoul@...nel.org>, CK Hu <ck.hu@...iatek.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Kishon Vijay Abraham I <kishon@...com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, stuart.lee@...iatek.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
        mac.shen@...iatek.com, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v3 04/12] drm/mediatek: extract common functions from the
 mtk hdmi driver

Il 04/11/22 15:09, Guillaume Ranquet ha scritto:
> Create a common "framework" that can be used to add support for
> different hdmi IPs within the mediatek range of products.
> 
> Signed-off-by: Guillaume Ranquet <granquet@...libre.com>
> ---
>   drivers/gpu/drm/mediatek/Makefile          |   3 +-
>   drivers/gpu/drm/mediatek/mtk_hdmi.c        | 620 ++---------------------------
>   drivers/gpu/drm/mediatek/mtk_hdmi.h        |  16 +
>   drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 433 ++++++++++++++++++++
>   drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 221 ++++++++++
>   5 files changed, 704 insertions(+), 589 deletions(-)
> 

..snip..

> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> new file mode 100644
> index 000000000000..3f08d37b1af0
> --- /dev/null
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c

..snip..

> +
> +int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz,
> +				 struct drm_display_mode *mode)

warning: no previous prototype for ‘mtk_hdmi_setup_avi_infoframe’ 
[-Wmissing-prototypes]

Please fix.

Thanks,
Angelo