linux-kernel - Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcec5536-6ba8-9cac-2001-710a7170df70@gmail.com>
Date:   Mon, 7 Nov 2022 12:18:26 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Elvis.Wang" <Elvis.Wang@...iatek.com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     "jason-jh . lin" <jason-jh.lin@...iatek.com>,
        Yongqiang Niu <yongqiang.niu@...iatek.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188



On 06/11/2022 11:27, Krzysztof Kozlowski wrote:
> On 04/11/2022 08:44, Elvis.Wang wrote:
>> From: Elvis Wang <Elvis.Wang@...iatek.com>
>>
>> add gce header file to define the gce thread priority, gce subsys id,
>> event and constant for mt8188.
>>
>> Signed-off-by: Elvis Wang <Elvis.Wang@...iatek.com>
>> ---
>> Thanks for the reviews, I have removed the incorrect reviewed message.
>> ---
>>   include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
>>   1 file changed, 966 insertions(+)
>>   create mode 100644 include/dt-bindings/gce/mediatek,mt8188-gce.h
>>
>> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h b/include/dt-bindings/gce/mediatek,mt8188-gce.h
>> new file mode 100644
>> index 000000000000..e2e2c56016a1
>> --- /dev/null
>> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h
> 
> 
> What is a "gce" subsystem or type of hardware? Why do you put headers in
> "gce"?
> 

Yes, I think we should move all header files from the gce folder into the 
mailbox folder.

Regards,
Matthias

> Don't continue this pattern. Mediatek devices do not get specific folders...
> 
> Best regards,
> Krzysztof
>