linux-kernel - Re: [PATCH 1/1] usb: dwc3: Do not get extcon device when usb-role-switch is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2jrQgj53z/mhHmm@smile.fi.intel.com>
Date:   Mon, 7 Nov 2022 13:25:54 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Janne Grunau <j@...nau.net>
Cc:     linux-usb@...r.kernel.org, Sven Peter <sven@...npeter.de>,
        stable@...nel.org, Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: dwc3: Do not get extcon device when
 usb-role-switch is used

On Sun, Nov 06, 2022 at 10:48:04PM +0100, Janne Grunau wrote:
> The change breaks device tree based platforms with PHY device and use
> usb-role-switch instead of an extcon switch. extcon_find_edev_by_node()
> will return EPROBE_DEFER if it can not find a device so probing without
> an extcon device will be deferred indefinitely. Fix this by
> explicitly checking for usb-role-switch.
> At least the out-of-tree USB3 support on Apple silicon based platforms
> using dwc3 with tipd USB Type-C and PD controller is affected by this
> issue.

We don't care about out-of-tree modules, do we?

OTOH, the problem you are trying to workaround is probably in a (mis)use of
deferred probe somewhere.

Btw, does it prevent the system boot or you just see the extcon in the list of
deferred devices after booting?

-- 
With Best Regards,
Andy Shevchenko