linux-kernel - Re: [PATCH 4/4] serial: 8250: Flush DMA Rx on RLSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2jumyyQKOsPhfcw@smile.fi.intel.com>
Date:   Mon, 7 Nov 2022 13:40:11 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        stable@...r.kernel.org, Gilles BULOZ <gilles.buloz@...tron.com>
Subject: Re: [PATCH 4/4] serial: 8250: Flush DMA Rx on RLSI

On Mon, Nov 07, 2022 at 01:07:08PM +0200, Ilpo Järvinen wrote:
> Returning true from handle_rx_dma() without flushing DMA first creates
> a data ordering hazard. If DMA Rx has handled any character at the
> point when RLSI occurs, the non-DMA path handles any pending characters
> jumping them ahead of those characters that are pending under DMA.
> 
> Fixes: 75df022b5f89 ("serial: 8250_dma: Fix RX handling")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
> Cc: Gilles BULOZ <gilles.buloz@...tron.com>

Maybe instead you can do --cc Guilles ... for entire series (and drop from
other commit messages)?

-- 
With Best Regards,
Andy Shevchenko