linux-kernel - Re: [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5873923.lOV4Wx5bFT@g550jk>
Date:   Mon, 07 Nov 2022 13:49:17 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     Lee Jones <lee@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        afd@...com, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon node name

On Montag, 7. November 2022 10:08:16 CET Lee Jones wrote:
> On Mon, 31 Oct 2022, Luca Weiss wrote:
> > extcon is a Linux-specific name and shouldn't be a part of the dts. Make
> > it be called usb-detect@ instead.
> > 
> > Signed-off-by: Luca Weiss <luca@...tu.xyz>
> > ---
> > This patch builds on top of
> > https://lore.kernel.org/linux-arm-msm/20221031173933.936147-1-luca@z3ntu.x
> > yz/ But could also be applied without, if conflicts are resolved.
> > 
> >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Same here.  Only 1/3 received.
> 
> Can I take this on its own?

Hi,

yes, this can be taken on its own. Perhaps it'll introduce some temporary 
dtbs_check warnings until the other patches have also made it into the tree.

Patch 2 is pm8941-misc yaml change, and patch 3 is adjusting dtsi file for the 
new name.

Lore: https://lore.kernel.org/lkml/20221031175717.942237-1-luca@z3ntu.xyz/

Regards
Luca

> 
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index
> > cf10d62ace54..14aa42057d6f 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > 
> > @@ -123,10 +123,6 @@ patternProperties:
> >        - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> >        - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > 
> > -  "extcon@[0-9a-f]+$":
> > -    type: object
> > -    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> > -
> > 
> >    "gpio(s)?@[0-9a-f]+$":
> >      type: object
> >      $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
> > 
> > @@ -143,6 +139,10 @@ patternProperties:
> >      type: object
> >      $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
> > 
> > +  "^usb-detect@[0-9a-f]+$":
> > +    type: object
> > +    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> > +
> > 
> >    "^usb-vbus-regulator@[0-9a-f]+$":
> >      type: object
> >      $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#