linux-kernel - Re: [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 21:28:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     'Guanjun' <guanjun@...ux.alibaba.com>, herbert@...dor.apana.org.au,
        elliott@....com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        zelin.deng@...ux.alibaba.com, artie.ding@...ux.alibaba.com,
        guanjun@...ux.alibaba.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, xuchun.shang@...ux.alibaba.com
Subject: Re: [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration

Hi 'Guanjun',

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.1-rc4 next-20221107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221103-154448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/1667461243-48652-3-git-send-email-guanjun%40linux.alibaba.com
patch subject: [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration
config: arm-randconfig-c002-20221106
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 2bbafe04fe785a9469bea5a3737f8d7d3ce4aca2)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/9f7d1fe6059378f16efdc261a6643c77ec627818
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221103-154448
        git checkout 9f7d1fe6059378f16efdc261a6643c77ec627818
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/crypto/ycc/ drivers/iio/addac/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/crypto/ycc/ycc_ring.c:41:6: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
                      ring->cmd_base_paddr, ring->resp_base_paddr);
                      ^~~~~~~~~~~~~~~~~~~~
   drivers/crypto/ycc/ycc_ring.c:41:28: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
                      ring->cmd_base_paddr, ring->resp_base_paddr);
                                            ^~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +41 drivers/crypto/ycc/ycc_ring.c

    28	
    29	/*
    30	 * Show the status of specified ring's command queue and
    31	 * response queue.
    32	 */
    33	static int ycc_ring_debugfs_status_show(struct seq_file *s, void *p)
    34	{
    35		struct ycc_ring *ring = (struct ycc_ring *)s->private;
    36	
    37		seq_printf(s, "Ring ID: %d\n", ring->ring_id);
    38		seq_printf(s, "Desscriptor Entry Size: %d, CMD Descriptor Size: %d, RESP Descriptor Size :%d\n",
    39			   ring->max_desc, YCC_CMD_DESC_SIZE, YCC_RESP_DESC_SIZE);
    40		seq_printf(s, "CMD base addr:%llx, RESP base addr:%llx\n",
  > 41			   ring->cmd_base_paddr, ring->resp_base_paddr);
    42		seq_printf(s, "CMD wr ptr:%d, CMD rd ptr: %d\n",
    43			   YCC_CSR_RD(ring->csr_vaddr, REG_RING_CMD_WR_PTR),
    44			   YCC_CSR_RD(ring->csr_vaddr, REG_RING_CMD_RD_PTR));
    45		seq_printf(s, "RESP rd ptr:%d, RESP wr ptr: %d\n",
    46			   YCC_CSR_RD(ring->csr_vaddr, REG_RING_RSP_RD_PTR),
    47			   YCC_CSR_RD(ring->csr_vaddr, REG_RING_RSP_WR_PTR));
    48	
    49		return 0;
    50	}
    51	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (223488 bytes)