linux-kernel - Re: [PATCH] virt: sev-guest: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c40b0b21-2a48-ffff-6568-fb55e8f9a15c@amd.com>
Date:   Mon, 7 Nov 2022 08:09:08 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Cole Robinson <crobinso@...hat.com>, Borislav Petkov <bp@...e.de>
Cc:     linux-coco@...ts.linux.dev, linux-kernel@...r.kernel.org,
        brijesh.singh@....com
Subject: Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS

On 11/5/22 11:08, Cole Robinson wrote:
> On 11/4/22 4:53 PM, Borislav Petkov wrote:
>> On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
>>> This fixes driver autoloading
>>
>> What is the scenario where this needs to be autoloaded?
>>
> 
> Any use case that needs /dev/sev-guest, I guess. Saves software from
> having to do the modprobe manually. For example, nothing I can find in
> https://github.com/AMDESE/sev-guest loads the driver, it expects
> /dev/sev-guest to be there already
> 
> Mostly I assumed lack of autoloading was an oversight. Was it
> intentionally omitted?

It probably was an oversight. To me, it makes sense to auto-load the 
module if the SNP support created the platform device as part of SNP 
initialization.

Thanks,
Tom

> 
> Thanks,
> Cole
>