linux-kernel - Re: [PATCH v3 04/13] mm/slab: Allow kmalloc() minimum alignment fallback to dma_get_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 08:50:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Catalin Marinas <catalin.marinas@....com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>, Christoph Hellwig <hch@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
        Will Deacon <will@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ard Biesheuvel <ardb@...nel.org>,
        Isaac Manjarres <isaacmanjarres@...gle.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Alasdair Kergon <agk@...hat.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Joerg Roedel <joro@...tes.org>,
        Mark Brown <broonie@...nel.org>,
        Mike Snitzer <snitzer@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 04/13] mm/slab: Allow kmalloc() minimum alignment
 fallback to dma_get_cache_alignment()

Hi Catalin,

I love your patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Catalin-Marinas/mm-dma-arm64-Reduce-ARCH_KMALLOC_MINALIGN-to-8/20221107-060303
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20221106220143.2129263-5-catalin.marinas%40arm.com
patch subject: [PATCH v3 04/13] mm/slab: Allow kmalloc() minimum alignment fallback to dma_get_cache_alignment()
config: parisc-randconfig-r003-20221106
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/309bc52a1ed9665a1b9d32bcf094918ceb6af519
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Catalin-Marinas/mm-dma-arm64-Reduce-ARCH_KMALLOC_MINALIGN-to-8/20221107-060303
        git checkout 309bc52a1ed9665a1b9d32bcf094918ceb6af519
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   mm/slab_common.c: In function '__kmalloc_minalign':
>> mm/slab_common.c:866:52: error: 'io_tlb_default_mem' undeclared (first use in this function)
     866 |             cache_align < ARCH_KMALLOC_MINALIGN || io_tlb_default_mem.nslabs)
         |                                                    ^~~~~~~~~~~~~~~~~~
   mm/slab_common.c:866:52: note: each undeclared identifier is reported only once for each function it appears in


vim +/io_tlb_default_mem +866 mm/slab_common.c

   856	
   857	static unsigned int __kmalloc_minalign(void)
   858	{
   859		int cache_align = dma_get_cache_alignment();
   860	
   861		/*
   862		 * If CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC is not enabled,
   863		 * ARCH_KMALLOC_MINALIGN matches ARCH_DMA_MINALIGN.
   864		 */
   865		if (!IS_ENABLED(CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC) ||
 > 866		    cache_align < ARCH_KMALLOC_MINALIGN || io_tlb_default_mem.nslabs)
   867			return ARCH_KMALLOC_MINALIGN;
   868	
   869		pr_info_once("No default DMA bounce buffer, increasing the kmalloc() minimum alignment to %d\n",
   870			     cache_align);
   871		return cache_align;
   872	}
   873	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (106561 bytes)