linux-kernel - RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001201d8f2a5$bcb8e870$362ab950$@samsung.com>
Date:   Mon, 7 Nov 2022 18:07:42 +0530
From:   "Inbaraj E" <inbaraj.e@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <chanho61.park@...sung.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        <tomasz.figa@...il.com>, "'Chanwoo Choi'" <cw00.choi@...sung.com>,
        "'ALIM AKHTAR'" <alim.akhtar@...sung.com>,
        <mturquette@...libre.com>, <sboyd@...nel.org>, <robh+dt@...nel.org>
Cc:     <linux-samsung-soc@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        "'PANKAJ KUMAR DUBEY'" <pankaj.dubey@...sung.com>
Subject: RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 07 November 2022 14:42
> To: chanho61.park@...sung.com; Inbaraj E <inbaraj.e@...sung.com>;
> Sylwester Nawrocki <s.nawrocki@...sung.com>; tomasz.figa@...il.com;
> Chanwoo Choi <cw00.choi@...sung.com>; ALIM AKHTAR
> <alim.akhtar@...sung.com>; mturquette@...libre.com;
> sboyd@...nel.org; robh+dt@...nel.org
> Cc: linux-samsung-soc@...r.kernel.org; linux-clk@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey@...sung.com>
> Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
> CMU_FSYS1 mmc card clock
> 
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller@...40000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is "gout"? "dout" had a meaning as clock divider output.
> >
> > "gout" is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
> 
> OK, then this should be in commit msg.
> 
> My question about full legal name remains, as here in replies I see "Inbaraj
> E".
> 

I have address your review comment, and posted v2. 
Thanks for review.

> Best regards,
> Krzysztof