linux-kernel - Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y2kdwms39CQUMQp/@sirena.org.uk>
Date:   Mon, 7 Nov 2022 15:01:22 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Venkata Prasad Potturu <venkataprasad.potturu@....com>
Cc:     Venkata Prasad Potturu 
        <venkataprasad.potturu@....corp-partner.google.com>,
        alsa-devel@...a-project.org, vsujithkumar.reddy@....com,
        Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ssabakar@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in
 machine driver

On Mon, Nov 07, 2022 at 04:04:40PM +0530, Venkata Prasad Potturu wrote:
> On 11/2/22 17:02, Mark Brown wrote:

> > Why would the user choose one value or the other, and why would this
> > choice be something that only changes at module load time?  If this is
> > user controllable I'd really expect it to be runtime controllable.
> > You're not explaining why this is a module parameter.

> Different vendors/OEM's use the same hardware as one need I2S mode and other
> need TDM mode, using common driver  to support  I2S and TDM mode with this
> parameter.

If a given board needs a specific configuration we should be configuring
based on identifying the board, not hoping that the user somehow knows
that this configuration is required and can work out how to do it.  If
this is purely a software setting depending on the software stack
running on the device then it should be selected at runtime by that
software as part of the use case management.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)