linux-kernel - Re: [PATCH 4/8] KVM: SVM: move guest vmsave/vmload to assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 15:47:59 +0000
From:   Andrew Cooper <Andrew.Cooper3@...rix.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "nathan@...nel.org" <nathan@...nel.org>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 4/8] KVM: SVM: move guest vmsave/vmload to assembly

On 07/11/2022 15:37, Paolo Bonzini wrote:
> On 11/7/22 16:32, Andrew Cooper wrote:
>>> -        vmload(svm->vmcb01.pa);
>>>           __svm_vcpu_run(vmcb_pa, svm);
>>> -        vmsave(svm->vmcb01.pa);
>>> -
>>>           vmload(__sme_page_pa(sd->save_area));
>>
>> %gs is still the guests until this vmload has completed.  It needs to
>> move down into asm too.
>
> Sure, that's patch 6 in the series.  See also cover letter: "this
> means moving guest vmload/vmsave and host vmload to assembly".

Oh, ok.  I missed that it was split across two patches.

Sorry for the noise.  The end result looks ok.

~Andrew